Correctly handle retries of classes with nested classes #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pavlo Shevchenko <[email protected]>
…-retry filter Signed-off-by: Pavlo Shevchenko <[email protected]>
pshevche
force-pushed
the
pshevche/handle-retries-of-classes-with-nested-classes
branch
from
77ac4a8 to
437a5e8
Compare
jean-andre-gauthier
approved these changes
Nov 20, 2023
marcphilipp
approved these changes
Nov 20, 2023
pshevche
deleted the
pshevche/handle-retries-of-classes-with-nested-classes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The test I implemented in 16a68b8 was not set up correctly to assert this behavior. All nested classes were retried because the top-level class itself had a failure and matched the retry filter. If the enclosing class did not have any method failures, then we wouldn't check if it matches the class retry filter.
With this change, we check if one of the parent classes matches the class-retry filter, and if so, retry it together with all of its nested classes.